Port LinePaginator from all bots. #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bot-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ChrisLovering
force-pushed
the
botcore-settings
branch
from
e5678fc
to
553e6eb
Compare
shtlrs
changed the title
shtlrs
force-pushed
the
botcore-settings
branch
from
cf3eb92
to
377d32a
Compare
This is because it's a component that can be reused by all bots.
shtlrs
force-pushed
the
botcore-settings
branch
2 times, most recently
from
568da3a
to
a0ced91
Compare
ChrisLovering
requested changes
Jan 4, 2024
shtlrs
force-pushed
the
botcore-settings
branch
from
a0ced91
to
e4c9b97
Compare
But I realized that I have only documented the class, not the methods themselves so I'll do that.
Yes that would be great, thanks. |
shtlrs
force-pushed
the
botcore-settings
branch
from
e4c9b97
to
bdc30b7
Compare
This will allow their reusability in all other bots
shtlrs
force-pushed
the
botcore-settings
branch
2 times, most recently
from
8d950e8
to
43b720a
Compare
wookie184
requested changes
Jan 5, 2024
shtlrs
force-pushed
the
botcore-settings
branch
from
43b720a
to
28001f7
Compare
shtlrs
force-pushed
the
botcore-settings
branch
from
6cda21d
to
aa021ea
Compare
wookie184
approved these changes
Jan 6, 2024
|
Oops, didn't mean to re-request your review wookie. Apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards having one single reusable core component to our bots instead of duplicate definitions all across them.
Problem
Amongst others,
LinePaginatoris a class used by all of our bots, sobot-coreshould be its home.The class has 2 main dependencies
Solution
Port it over to bot-core, and have all other bots import & use it.
The
message.reaction_checkutil has been ported to bot-coreThe main problem for now remains with the usage of constants. To tacke this, the idea is to make a wrapper over this
LinePaginatorin all clients that will inject the emojis instead of having to do it each time the paginator is needed.